search

getsentry / rrweb

record and replay the web
https://www.rrweb.io/
Other
9 stars 5 forks source link

fix: dimensions not being applied #117

Closed billyvg closed 9 months ago

billyvg commented 9 months ago

Dimensions are not being properly applied when you seek to a position in the replay. Need to use setProperty, otherwise the style attributes get lost.

billyvg commented 9 months ago

It actually is covered in sentry-javascript, but we missed it: https://github.com/getsentry/sentry-javascript/pull/8760/files#diff-c0b1773a4acdadc0e23d17df2f9c8a3d13be5a62e01dff6a79e894d58721a84eL174

I'll see how easy it is to add a test here since it'd be easier to spot.

mydea commented 9 months ago

TODO: I guess we should also upstream this?