Revert "feat: Remove `plugins` related code, which is not used (#123)"

getsentry / rrweb

record and replay the web

https://www.rrweb.io/

Other

12 stars 5 forks source link

Revert "feat: Remove `plugins` related code, which is not used (#123)" #133

Closed billyvg closed 10 months ago

billyvg commented 10 months ago

This reverts commit 42ffd923d62cb3ba6e976ccc65e1cdf517991b98.

We need plugins to enable our custom canvas playback method. We can keep record plugins removed as we don't use them.

github-actions[bot] commented 10 months ago

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.78 KB (+1.12% 🔺)
rrweb - record & getCanvasManager only (gzipped)	22.92 KB (+1.65% 🔺)
rrweb - record only (min)	57.74 KB (+0.98% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.55 KB (+1.28% 🔺)

mydea commented 10 months ago

It's not a huge amount of code so I'd vote to keep all of it, if we keep some of the plugins code and not other it may become confusing in the future!

billyvg commented 10 months ago

@mydea done!