search

getsentry / rrweb

record and replay the web
https://www.rrweb.io/
Other
9 stars 5 forks source link

Revert "fix: isCheckout is not included in fullsnapshot event (#1141)" #139

Closed billyvg closed 7 months ago

billyvg commented 7 months ago

This reverts commit 3416c3a769e2bd2ddfbb88f5c4ff139871c567be.

From my comment here

I only used translate on the OP but if I understand correctly, when we call takeFullSnapshot(true), we will receive two distinct events with the isCheckout arg as true. Looking at the blame this is due to #1141.

If you use checkoutEvery... and rely on isCheckout to reset existing events, this means that the Meta event will be lost because the FullSnapshot occurs afterwards, and isCheckout is true for both events. Losing the Meta event means that the replayer will be unable to set its dimensions, making the replay look broken.