feat(canvas): Bind `mutationCb` outside of `getCanvasManager`

getsentry / rrweb

record and replay the web

https://www.rrweb.io/

Other

9 stars 5 forks source link

feat(canvas): Bind `mutationCb` outside of `getCanvasManager` #141

Closed billyvg closed 7 months ago

billyvg commented 7 months ago

From what I can tell, record ends up getting bundled separate from getCanvasManager in user-land code and canvas mutation events end up not being transmitted because _wrappedEmit does not get set and it will hold the wrong mirror reference.

github-actions[bot] commented 7 months ago

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.84 KB (+0.37% 🔺)
rrweb - record & getCanvasManager only (gzipped)	22.92 KB (+0.01% 🔺)
rrweb - record only (min)	57.94 KB (+0.37% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.59 KB (+0.29% 🔺)