ref: Avoid async in canvas

getsentry / rrweb

record and replay the web

https://www.rrweb.io/

Other

9 stars 5 forks source link

ref: Avoid async in canvas #143

Closed mydea closed 7 months ago

mydea commented 7 months ago

Related to https://github.com/getsentry/rrweb/pull/142, noticed that this is kind of unnecessary (and is transpiled in pre-ES2017 envs). Passing an async function to forEach is anyhow a bit weird I'd say.

github-actions[bot] commented 7 months ago

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.57 KB (0%)
rrweb - record & getCanvasManager only (gzipped)	19.13 KB (+0.1% 🔺)
rrweb - record only (min)	56.53 KB (0%)
rrweb - record with treeshaking flags (gzipped)	15.35 KB (0%)