search

getsentry / rrweb

record and replay the web
https://www.rrweb.io/
Other
9 stars 5 forks source link

feat: Remove `getCanvasManager`, export `CanvasManager` class directly #153

Closed billyvg closed 6 months ago

billyvg commented 6 months ago

This simplifies the code a bit by exporting the CanvasManager directly. With ReplayCanvas, we can rely on it for complex setup, but keeps it simple for our users.

github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.67 KB (-0.15% 🔽)
rrweb - record & getCanvasManager only (gzipped) 0 B (removed)
rrweb - record only (min) 56.91 KB (-0.07% 🔽)
rrweb - record with treeshaking flags (gzipped) 15.46 KB (-0.17% 🔽)
rrweb - record & CanvasManager only (gzipped) 19.21 KB (added)
mydea commented 6 months ago

hmm if this does not mess with tree shaking (always hard to say in this code base 😬 ) then looks good to me!

billyvg commented 6 months ago

Seems like tree shaking still works according to size-limit!