search

getsentry / rrweb

record and replay the web
https://www.rrweb.io/
Other
9 stars 5 forks source link

feat(replay): Add isManualSnapshot to record #157

Closed c298lee closed 6 months ago

c298lee commented 6 months ago

Add isManualSnapshot to record so the option can be passed in to canvasManager.

Relates to https://github.com/getsentry/team-replay/issues/308

github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.69 KB (+0.05% 🔺)
rrweb - record & CanvasManager only (gzipped) 19.33 KB (+0.03% 🔺)
rrweb - record only (min) 57 KB (+0.11% 🔺)
rrweb - record with treeshaking flags (gzipped) 15.48 KB (+0.09% 🔺)
billyvg commented 6 months ago

Is this needed since CanvasManager accepts this option? https://github.com/getsentry/rrweb/pull/149/files#diff-0101f09f6896a91d9109539b51f0a0f9157cd44ab33486ddd78734ad801edbf2R121-R123

c298lee commented 6 months ago

After discussion, closing for now as we are passing this option directly into canvas manager. We will add this option into record in the future, as well as modifying canvas manager to make an upstream PR to rrweb with the new snapshot changes