search

getsentry / rrweb

record and replay the web
https://www.rrweb.io/
Other
9 stars 4 forks source link

fix(snaptshot): Ensure `attr.name` is defined when collecting element attributes #160

Closed Lms24 closed 5 months ago

Lms24 commented 5 months ago

Probably fixes https://github.com/getsentry/sentry-javascript/issues/10292

Not sure how attr.name could be undefined here but according to the issue, it happens and we should probably guard adding the attribute.

Open question (see my comment)

github-actions[bot] commented 5 months ago

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.69 KB (+0.04% 🔺)
rrweb - record & CanvasManager only (gzipped) 19.34 KB (+0.03% 🔺)
rrweb - record only (min) 56.95 KB (+0.02% 🔺)
rrweb - record with treeshaking flags (gzipped) 15.47 KB (+0.04% 🔺)