search

getsentry / rrweb

record and replay the web
https://www.rrweb.io/
Other
9 stars 4 forks source link

feat: support recording canvas in iframe and shadow dom #168

Closed p-mazhnik closed 1 month ago

p-mazhnik commented 3 months ago

Resolves https://github.com/getsentry/sentry-javascript/issues/10758

rrweb PR: https://github.com/rrweb-io/rrweb/pull/1428

Before

Red square is on the main page;
Green is inside the shadow dom on the main page;
Blue one is within the iframe;
Pink is inside the shadow dom within the iframe.

After
billyvg commented 3 months ago

@p-mazhnik This is great, I can take a look at this next week

billyvg commented 1 month ago

@p-mazhnik Do you have "Allow edits by maintainers" enabled on this PR? I can't seem to push to your branch

p-mazhnik commented 1 month ago

Do you have "Allow edits by maintainers" enabled on this PR?

I do. I've added you to my fork as well just in case

billyvg commented 1 month ago

@p-mazhnik thanks, ah I think the perm issues were due to tags

billyvg commented 1 month ago

Thanks for the contribution @p-mazhnik! Sorry it took so long to merge.