search

getsentry / rrweb

record and replay the web
https://www.rrweb.io/
Other
9 stars 5 forks source link

fix: more robust `rootShadowHost` check #50

Closed mydea closed 1 year ago

mydea commented 1 year ago

This may be the underlying cause here, maybe an e.g. undefined sneaked in there somehow. IMHO this should also safe some bytes.

billyvg commented 1 year ago

Note this was reported upstream as well: https://github.com/rrweb-io/rrweb/issues/1114

YunFeng0817 commented 1 year ago

https://github.com/rrweb-io/rrweb/pull/891/files

image

This is a similar fix.

mydea commented 1 year ago

https://github.com/rrweb-io/rrweb/pull/891/files image

This is a similar fix.

Ah, interesting, so I guess we can merge this after all!

Lms24 commented 1 year ago

Should fix https://github.com/getsentry/sentry-javascript/issues/7274