search

getsentry / rrweb

record and replay the web
https://www.rrweb.io/
Other
9 stars 5 forks source link

fix: First record is checkout #56

Closed mydea closed 1 year ago

mydea commented 1 year ago

In order to streamline our checkout check, it makes much more sense IMHO that the first emit is considered a checkout.

billyvg commented 1 year ago

🤔 -- I wonder why rrweb did not have this in the first place?

mydea commented 1 year ago

Yes, I wondered the same. It is also that way in current master - I'll also create a PR there!

billyvg commented 1 year ago

Yeah it would good if we can gain some insight first

mydea commented 1 year ago

ref https://github.com/rrweb-io/rrweb/pull/1150

mydea commented 1 year ago

Closing this as this is apparently by design - see: https://github.com/rrweb-io/rrweb/pull/1150