getsentry / rrweb

record and replay the web
https://www.rrweb.io/
Other
9 stars 5 forks source link

fix(build/CI): Run prepublish scripts before building tarballs #64

Closed Lms24 closed 1 year ago

Lms24 commented 1 year ago

Previously, in the "Upload Artifacts" job, we didn't explicitly run a build command but instead relied on the package-specific prepack yarn scripts. This caused an incomplete @sentry-internal/rrweb-player package, as this package didn't have a prepack script. This PR now adds a step to the CI job to actually run the prepublish build command before packing the tarballs.

I checked the resulting tarball against the actual rrweb player and it seems all files are present now. Uploaded artifacts of a test branch: https://github.com/getsentry/rrweb/actions/runs/4263220937

Misc: This PR also updates a type declaration file that was stale beforehand.

closes #63