since technically both options have the same "value" now, when a user selects an option it may not reflect the longer text in the select box. However, I'd say that is OK, and better than to leak the values.
In addition, this also makes sure to mask value of radio/checkbox inputs. Note this only affects value='****' of these elements when maskAllInputs=true, not the content of their labels (which is masked via maskAllText: true).
This ensures we mask
<option>
when selects should be masked.We mask both the
value
attribute as well as the text content of the<option>
.note that due to how masking work, the replay may not look completely correct. E.g. if you have the following:
it is masked to:
since technically both options have the same "value" now, when a user selects an option it may not reflect the longer text in the select box. However, I'd say that is OK, and better than to leak the values.
In addition, this also makes sure to mask
value
of radio/checkbox inputs. Note this only affectsvalue='****'
of these elements whenmaskAllInputs=true
, not the content of their labels (which is masked viamaskAllText: true
).Closes https://github.com/getsentry/rrweb/issues/74
See https://sentry-sdks.sentry.io/replays/javascript-vue-replays:7189262e513742719dbce6e5fe4556aa/?query=&referrer=%2Freplays%2F&statsPeriod=14d&yAxis=count%28%29 for a replay in action.