search

getsentry / rust-sourcemap

A library for rust that implements basic sourcemap handling
Other
224 stars 27 forks source link

Propagate cfg guards from rust-url #19

Closed RReverser closed 5 years ago

RReverser commented 5 years ago

Guard APIs that depend on Url::to_file_path and Url::from_directory_path on the same platforms as rust-url.

This allows to compile rust-sourcemap on other platforms (e.g. wasm32-unknown-unknown) without errors.

RReverser commented 5 years ago

@mitsuhiko The failure doesn't seem relevant - just a Clippy upgrade that should be fixed on master.

dashed commented 5 years ago

This should now be addressed in https://github.com/getsentry/rust-sourcemap/pull/20

RReverser commented 5 years ago

Yup, thanks, looks like Travis passed now that you merged it. Can someone take a look at this PR too please?

RReverser commented 5 years ago

Ping @mitsuhiko?

mitsuhiko commented 5 years ago

Will release. thanks!

RReverser commented 5 years ago

Thank you!