search

getsentry / rust-sourcemap

A library for rust that implements basic sourcemap handling
Other
224 stars 27 forks source link

refactor: make SourceView implement Sync #80

Closed underfin closed 7 months ago

underfin commented 7 months ago

Close https://github.com/getsentry/rust-sourcemap/issues/79

Swatinem commented 7 months ago

While this is a change definitely worth having, long term, I would rather get rid of SourceView completely. I don’t think its fully written down in https://github.com/getsentry/rust-sourcemap/issues/71, but definitely something we should work towards.

underfin commented 7 months ago

@Swatinem Thanks for your review, i already update code. If you merged this, could you publish a new version for this? Thank you for your work.

underfin commented 7 months ago

@Swatinem Could you publish a new version for this? Thanks.