search

getsentry / rust-sourcemap

A library for rust that implements basic sourcemap handling
Other
224 stars 27 forks source link

Turn `debug_id` field to `debugId` #96

Open lforst opened 2 weeks ago

lforst commented 2 weeks ago

The relevant TC39 proposal proposes debug IDs to be in camelCase (debugId): https://github.com/tc39/source-map/blob/8be0fe10ad042e13f4196d17b44ddedfd6a9df58/proposals/debug-id.md?plain=1#L111

We probably need to figure out some sort of migration path or cut a major for this?

loewenheim commented 2 weeks ago

At least for parsing/deserialization this shouldn't be a problem—we can change the serialized field name to debugId and keep debug_id as a serde::alias so it can still be read. But I guess it would still count as a breaking change because serialization behavior changes.

lforst commented 2 weeks ago

At least for parsing/deserialization this shouldn't be a problem—we can change the serialized field name to debugId and keep debug_id as a serde::alias so it can still be read. But I guess it would still count as a breaking change because serialization behavior changes.

Fully agree. Versions are free so we should just be careful and do a major if we change it.