All links under point performance are broken

getsentry / self-hosted

Sentry, feature-complete and packaged up for low-volume deployments and proofs-of-concept

https://develop.sentry.dev/self-hosted/

Other

7.49k stars 1.7k forks source link

All links under point performance are broken #3145

Open michaelmairegger opened 1 week ago

michaelmairegger commented 1 week ago

Self-Hosted Version

24.6.0

CPU Architecture

x86_64

Docker Version

24.0.7

Docker Compose Version

2.27.1

Steps to Reproduce

Click on Queries and the new page shows:

The organization you were looking for was not found.

Expected Result

For e.g. queries the folowing URL should open: https://.../organizations/sentry/insights/database/

Actual Result

For e.g. queries the following URL opens:

https://.../insights/database/

Event ID

No response

cavanierc commented 1 week ago

Hello, I have the same issue after upgrade to 24.6.0

SmoshySmosh commented 1 week ago

I am currently experiencing the same after upgrading.

aldy505 commented 1 week ago

@KevinL10 @gggritso Hey, do you guys know anything related to this? I saw this PR that probably made the change, but since it's included in 24.5.1, I'm not too sure.

pavel-boev commented 1 week ago

Enabling of feature "organizations:performance-insights" fixed this for me, but I still have useless "Caches", "Queues" and "LLM Monitoring" in navigation

aldy505 commented 1 week ago

Enabling of feature "organizations:performance-insights" fixed this for me, but I still have useless "Caches", "Queues" and "LLM Monitoring" in navigation

@pavel-boev Would you like to add these features and then re-run install.sh script?

    # Rename current Performance modules to "Insights"
    "organizations:performance-insights",
    # Show links and upsells to Insights modules
    "organizations:insights-entry-points",
    # Enable access to initial Insights modules (Queries, Requests, Vitals, App Starts, Page Loads, Resources)
    "organizations:insights-initial-modules",
    # Enable access to newer Insights modules (Caches, Queues, LLMs, Mobile UI)
    "organizations:insights-addon-modules",

(from https://github.com/getsentry/sentry/blob/b0a45b072fb0cfceec3be5cad8e7a06ac58e60b1/src/sentry/features/temporary.py#L224-L225 and https://github.com/getsentry/sentry/blob/b0a45b072fb0cfceec3be5cad8e7a06ac58e60b1/src/sentry/features/temporary.py#L399-L404)

pavel-boev commented 1 week ago

I prefer to keep "organizations:insights-addon-modules" disabled, because we don't use sentry for backend. But I still see these modules in the navigation with the disabled feature.

LordSimal commented 1 week ago

Adding the 3 feature flags mentioned above to the sentry/sentry.conf.py and doing a ./install.sh does not fix this issue.

Its just weird, that the main menu item for Performance is working ( aka the link /organizations/myorg/performance/) but any link underneath (like /organizations/myorg/performance/database/) redirects to /insights/database/

In fact if I manually enter the URL /organizations/myorg/insights/database/ it works just fine. So something is stripping the /organizations/myorg/ part of the URL

zKoz210 commented 1 week ago

@LordSimal work for me

    "organizations:performance-insights",
    # Show links and upsells to Insights modules
    "organizations:insights-entry-points",
    # Enable access to initial Insights modules (Queries, Requests, Vitals, App Starts, Page Loads, Resources)
    "organizations:insights-initial-modules",
    # Enable access to newer Insights modules (Caches, Queues, LLMs, Mobile UI)
    "organizations:insights-addon-modules",

LordSimal commented 1 week ago

Indeed, I was missing organizations:performance-insights as well, so the following 2 features should be added to the sentry.config.py (as well as the sentry.config.example.py in this repo 😉)

"organizations:insights-addon-modules",
"organizations:performance-insights",

with that all the menu items work again

gggritso commented 1 week ago

👋🏻 hi everyone, sorry about the linking confusion!

"organizations:performance-insights" was removed in https://github.com/getsentry/sentry/pull/72962 a few days ago, so the next release of self-hosted doesn't need it
"organizations:insights-entry-points", "organizations:insights-initial-modules" and "organizations:insights-addon-modules" should be enabled

@aldy505 do you mind making that change and/or pointing me to where I should make it?

stumbaumr commented 3 days ago

This was the first issue I found regarding the error message: https://github.com/getsentry/sentry/issues/53431 Linking it here to make this issue appear over there...

aldy505 commented 3 days ago

This was the first issue I found regarding the error message: https://github.com/getsentry/sentry/issues/53431

Linking it here to make this issue appear over there...

@stumbaumr This issue is not related to session replay. Are you referring to other issue? Or can you specify more of what you're experiencing?