search

getsentry / self-hosted

Sentry, feature-complete and packaged up for low-volume deployments and proofs-of-concept
https://develop.sentry.dev/self-hosted/
Other
7.49k stars 1.7k forks source link

feat: add insights feature flags #3152

Open aldy505 opened 1 week ago

aldy505 commented 1 week ago

Closes #3145

After this is merged, we should create a new patch release 24.6.1 to handle that specific issue, since during the time of the self-hosted release, the Insights team ported a few changes from Performance -> Insights.

Also removes spans-first-ui per this PR https://github.com/getsentry/sentry/pull/72255

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

aldy505 commented 3 days ago

@gggritso Should we also add "organizations:indexed-spans-extraction"? I don't know what it's used for but it's there on the feature flag list..

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.01%. Comparing base (da06c0f) to head (c8604c7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3152 +/- ## ======================================= Coverage 99.01% 99.01% ======================================= Files 3 3 Lines 203 203 ======================================= Hits 201 201 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gggritso commented 3 days ago

@aldy505 yes, definitely! Sorry I missed it, I thought it was already there

aldy505 commented 3 days ago

@gggritso It turns out the indexed-span-extraction is already there. You can review the PR now.

aldy505 commented 3 days ago

@hubertdeng123 Do you want to cut a release for this? Or do you prefer to wait for next month's?