search

getsentry / self-hosted

Sentry, feature-complete and packaged up for low-volume deployments and proofs-of-concept
https://develop.sentry.dev/self-hosted/
Other
7.49k stars 1.7k forks source link

Build always shows as unknown in self-hosted #3165

Open andrea-berling opened 6 days ago

andrea-berling commented 6 days ago

Environment

self-hosted (https://develop.sentry.dev/self-hosted/)

Steps to Reproduce

  1. Go to https://hub.docker.com/layers/getsentry/sentry/24.5.1/images/sha256-4c6e8885468559da05839b9f4034dcd80eaed6c67a7787f02b0e0fde08a422b4?context=explore
  2. Check out the value of SENTRY_BUILD at line 46

Expected Result

SENTRY_BUILD should point to the commit sha that was checked out when the Docker image was built

Actual Result

SENTRY_BUILD is set to unknown, indicating that the proper build argument (SOURCE_COMMIT) was not provided when the image was built. Compare with Dockerfile, ARG SOURCE_COMMIT. As a result, this is what is shown in the footer:

image

Product Area

Footer

Link

No response

DSN

No response

Version

24.5.1

getsantry[bot] commented 6 days ago

Assigning to @getsentry/support for routing ⏲️

aldy505 commented 5 days ago

It's a known issue, but it doesn't impact anything though. The commit sha should be there. https://github.com/getsentry/sentry/blob/5f49d2a6ef0e41c57c0229d7125d8ab42571db29/static/app/components/footer.tsx#L39-L48