search

getsentry / self-hosted

Sentry, feature-complete and packaged up for low-volume deployments and proofs-of-concept
https://develop.sentry.dev/self-hosted/
Other
7.77k stars 1.75k forks source link

Tags for 24.5.x removed #3172

Closed dlouzan closed 3 months ago

dlouzan commented 3 months ago

Self-Hosted Version

-

CPU Architecture

-

Docker Version

-

Docker Compose Version

-

Steps to Reproduce

We deployed 24.5.0 last month and we just realized that the tags are gone. Was this intended? The changelog still lists them though: https://github.com/getsentry/self-hosted/blob/master/CHANGELOG.md

Expected Result

Tags for 24.5.0 and 24.5.1 are available.

Actual Result

No tags available: https://github.com/getsentry/self-hosted/tags

Event ID

No response

dlouzan commented 3 months ago

/cc @max-wittig @ercanucan

hubertdeng123 commented 3 months ago

Yes, this was intentional. See here for more details: https://github.com/getsentry/self-hosted/issues/3167

liukch commented 3 months ago

Yes, this was intentional. See here for more details: #3167

No!!!! Please do not do that. A lot of people use these version in prod env. What if they meet some accident, where for them to find out these code?

This is irreversible. The correct approach is to add some comments in a prominent position for version 24.6.x.

max-wittig commented 3 months ago

I agree with @liukch. We had to run REINDEX index sentry_groupedmessage_view; for the DB upgrade to succeed and after reading the comments in https://github.com/getsentry/self-hosted/issues/3167, I'm not sure that this was enough.

I know this is free software and we cannot expect anything, but this is not a way to handle upgrades.

dlouzan commented 3 months ago

Well, I agree with the other posters that removing git tags is a pretty weird move, but I guess since there's no packages you have no way to "yank" a version. We'll keep an eye on the linked issues. Thanks!