search

getsentry / sentry-auth-saml2

SAML2 SSO provider for Sentry
Apache License 2.0
19 stars 19 forks source link

error with from django.forms.util import ErrorList #44

Closed Uporaba1 closed 5 years ago

Uporaba1 commented 5 years ago

There was a problem when adding the sentry-auth-saml2 module through the command specified in the documentation: pip install https://github.com/getsentry/sentry-auth-saml2/archive/master.zip

after installing the module, the sentry crashed with an error: image

File "/usr/local/lib/python2.7/site-packages/sentry_auth_saml2/forms.py", line 4, in <module>
from django.forms.utils import ErrorList
ImportError: no module named utils

In file sentry_auth_saml2 / forms.py need to change: django.forms.utils import ErrorList on django.forms.util import ErrorList

After change: image

You broke it 22 days ago. I created a pull request to fix this error.

Uporaba1 commented 5 years ago

@joshuarli can u fix it pls?

joshuarli commented 5 years ago

master's being made compatible with Django 1.9, which sentry master will be on soon. I should have done it in a backwards compatible manner though. For now, you can just install https://github.com/getsentry/sentry-auth-saml2/archive/e519afe24bfc8778ca7797a1878a62bff4b29dfd.zip which doesn't have those changes.

I won't be changing it to be backwards compatible; we're going to be moving these external plugin repositories into sentry very soon anyways.

mbarrien commented 5 years ago

For people running the open source version, does this mean we'll be seeing a tagged version of Sentry 10.0 soon, or are we expected to install from HEAD of sentry master (with the corresponding lack of documentation)?

Having this barely documented workaround for people running from the most recently tagged Sentry would be a poor user experience. At the minimum this should be mentioned in the README for people running/installing Sentry 9.1.2.

joshuarli commented 5 years ago

@mbarrien I looked into this more and turns out Sentry 9.1.2 is running on Django 1.6 - keeping backwards compat for that version of Django totally went over my head, haha. So sorry about that. You're right that that workaround is a poor user experience; fIxed in https://github.com/getsentry/sentry-auth-saml2/pull/46.

mbarrien commented 5 years ago

Thanks for restoring the backwards compatibility! Would be even more excited if there was an update announced about https://forum.sentry.io/t/when-will-a-new-version-be-tagged-for-sentry-open-source/5622 for Sentry 10.0!

joshuarli commented 5 years ago

I'd guess at the very latest, by december :) Stay tuned.