search

getsentry / sentry-cli

A command line utility to work with Sentry.
https://docs.sentry.io/cli/
BSD 3-Clause "New" or "Revised" License
899 stars 221 forks source link

`sourcemaps inject` should fall back to co-located source maps if exact path can't be found #1870

Closed brettdh closed 2 months ago

brettdh commented 10 months ago

Environment

What version of the CLI and what OS are you running?

Sentry CLI 1.23.0, macOS Ventura 13.4

Steps to Reproduce

Similar to #1846:

  1. Create a .js file with a corresponding .js.map file in the same directory
  2. Add a source map comment pointing to a path that doesn't exist locally; e.g. 
    //# sourceMappingURL=/_static/build/foo.js.map

    Note: this is a mostly-real example from a starter Remix app. The path here is the default when creating a new app from the grunge stack, but this issue will occur for any static assets path, whether or not it has a URL scheme and domain.

  3. Run sentry-cli sourcemaps inject foo.js*

Alternatively, though it was created to repro a different bug, you can also repro this bug by following the steps here, ignoring the AWS bits and running npm run build instead of any of the other scripts. The sentry-cli sourcemaps inject step will show missing debug IDs for the sourcemap files.

Expected Result

JS file and sourcemap file both have debug ID injected

Actual Result

Only JS file has debug ID injected

Logs

When filing a bug report, please attach debug logs, either by using --log-level=debug flag or SENTRY_LOG_LEVEL=debug environment variable.

adinauer commented 10 months ago

@brettdh thanks for opening this issue. Might take a while for us to look at it with the holidays coming up.

brettdh commented 10 months ago

Should have mentioned - I'm working on a PR already, as it's a trivial addition to my last one.

github-actions[bot] commented 9 months ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

brettdh commented 9 months ago

Sorry, I've let the PR here become idle. I'll try to get back to it soon.

szokeasaurusrex commented 9 months ago

I put a "Status: Backlog" label on this PR so StaleBot keeps it open