getsentry / sentry-cli

A command line utility to work with Sentry.
https://docs.sentry.io/cli/
BSD 3-Clause "New" or "Revised" License
899 stars 221 forks source link

Quite confusing log message #2137

Closed lforst closed 1 month ago

lforst commented 1 month ago

WARN 2024-09-02 14:41:35.566111677 +00:00 Using https://sentry.io (embedded in token) rather than manually-configured URL https://sentry.io. To use https://sentry.io, please provide an auth token for this URL.

I am getting this in our Changelog Vercel logs. https://vercel.com/sentry/changelog/DT2tEb1huCLLTUm7DzDaWawhZHzi#L159

IMO, if the manually provided URL, and the URL in the auth token are matching, we should not print this message.

cc @szokeasaurusrex

szokeasaurusrex commented 1 month ago

strange – I thought I was only printing this when the two URLs are different, but I will double check

szokeasaurusrex commented 1 month ago

Okay, looks like in one of the places we emit this message we check whether the URLs are different, but in the other spot, we don't:

https://github.com/getsentry/sentry-cli/blob/288382f2b68f29cbee0c0b1a943b31bfbf4d0390/src/config.rs#L74-L83

Should be a pretty simple fix to add this check, thanks for raising @lforst!

dmadridy commented 1 month ago

Hey, just got this message as well when configuring Sentry. Let me know when its solved. Thanks!

szokeasaurusrex commented 1 month ago

@dmadridy hopefully we will get a fix out this week!

szokeasaurusrex commented 1 month ago

@dmadridy @lforst, the fix has been released in Sentry CLI v2.35.0.

absolutegravitas commented 1 month ago

yeesh... What is the actual patch and what does this mean? I have a repo https://github.com/midday-ai/v1 whose deployment to vercel fails because of this unnecessarily confusing message . Upgrading packages for that repo doesnt fix the issue (it's got @sentry/nextjs package).

yeesh

Image

lforst commented 1 month ago

@absolutegravitas The log message is confusing but it should not fail your build. You can basically ignore it.