getsentry / sentry-cocoa

The official Sentry SDK for iOS, tvOS, macOS, watchOS.
https://sentry.io/for/cocoa/
MIT License
808 stars 319 forks source link

Missing layoutSubviews spans for non animating viewControllers transaction #1506

Open brustolin opened 2 years ago

brustolin commented 2 years ago

When a new viewController is presented without animation the ui life cycle changes. With animation, the last method to be called is viewDidAppear, and we finish the transaction in this one. Without animation, methods related to layout subviews are called after viewDidAppear, and we don't measure them. Depending on the the amount of subviews, those methods can take a while, and thats why is important to measure them.

philipphofmann commented 2 years ago

We could solve this with waitWithTimeout similar as we have it on Flutter and JavaScript. Maybe we can also detect in the run loop or through screen rendering when the UIViewController finishes.

github-actions[bot] commented 2 years ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

brustolin commented 2 years ago

I believe this need to be on backlog.

github-actions[bot] commented 2 years ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

philipphofmann commented 8 months ago

Is this still an issue @brustolin?