search

getsentry / sentry-cocoa

The official Sentry SDK for iOS, tvOS, macOS, watchOS.
https://sentry.io/for/cocoa/
MIT License
768 stars 307 forks source link

SentryProfilerState doesn't respect `debug` option setting #3943

Closed jboulter11 closed 1 week ago

jboulter11 commented 1 week ago

Platform

iOS

Environment

Develop

Installed

Manually

Version

Commit 74cf23b2

Did it work on previous versions?

Not sure

Steps to Reproduce

  1. stand up sentry with debug = false but tracing and profiling at 100% so you will profile your session
  2. Restart the app until you begin profiling

Expected Result

  1. no debug logs are printed to the console

Actual Result

SentryProfilerState obliterates the log output, uses printf directly instead of SentryLog.

Are you willing to submit a PR?

Probably not

jboulter11 commented 1 week ago

Screenshot by Dropbox Capture

jboulter11 commented 1 week ago

Screenshot by Dropbox Capture snippet from SentryProfilerState.mm

kahest commented 1 week ago

Hey @jboulter11 thanks for the report - we have removed these in release 8.22.0 (PR) - are you able to update to that version?

jboulter11 commented 1 week ago

Yes, it's in my queue to update to use the new xcframeworks. Thanks for letting me know about the fix.