search

getsentry / sentry-cocoa

The official Sentry SDK for iOS, tvOS, macOS, watchOS.
https://sentry.io/for/cocoa/
MIT License
773 stars 306 forks source link

impr: Send Cocoa SDK features #3948

Closed philipphofmann closed 3 weeks ago

philipphofmann commented 3 weeks ago

:scroll: Description

Send enabled Cocoa SDK features with the event payload so that we can track their adoption in Looker.

:bulb: Motivation and Context

See https://github.com/getsentry/team-sdks/issues/83.

:green_heart: How did you test it?

Unit tests and sending an event via a simulator.

:pencil: Checklist

You have to check all boxes before merging:

:crystal_ball: Next steps

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.795%. Comparing base (7bdf989) to head (4c15f4b).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948/graphs/tree.svg?width=650&height=150&src=pr&token=PTZKtOJlrs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) ```diff @@ Coverage Diff @@ ## main #3948 +/- ## ============================================= - Coverage 90.806% 90.795% -0.011% ============================================= Files 588 590 +2 Lines 45879 45945 +66 Branches 16370 16378 +8 ============================================= + Hits 41661 41716 +55 + Misses 4148 4049 -99 - Partials 70 180 +110 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [Sources/Sentry/SentryClient.m](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948?src=pr&el=tree&filepath=Sources%2FSentry%2FSentryClient.m&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-U291cmNlcy9TZW50cnkvU2VudHJ5Q2xpZW50Lm0=) | `95.971% <100.000%> (+0.028%)` | :arrow_up: | | [...es/Swift/Helper/SentryEnabledFeaturesBuilder.swift](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948?src=pr&el=tree&filepath=Sources%2FSwift%2FHelper%2FSentryEnabledFeaturesBuilder.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-U291cmNlcy9Td2lmdC9IZWxwZXIvU2VudHJ5RW5hYmxlZEZlYXR1cmVzQnVpbGRlci5zd2lmdA==) | `100.000% <100.000%> (ø)` | | | [...sts/Helper/SentryEnabledFeaturesBuilderTests.swift](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948?src=pr&el=tree&filepath=Tests%2FSentryTests%2FHelper%2FSentryEnabledFeaturesBuilderTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-VGVzdHMvU2VudHJ5VGVzdHMvSGVscGVyL1NlbnRyeUVuYWJsZWRGZWF0dXJlc0J1aWxkZXJUZXN0cy5zd2lmdA==) | `100.000% <100.000%> (ø)` | | | [Tests/SentryTests/SentryClientTests.swift](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948?src=pr&el=tree&filepath=Tests%2FSentryTests%2FSentryClientTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-VGVzdHMvU2VudHJ5VGVzdHMvU2VudHJ5Q2xpZW50VGVzdHMuc3dpZnQ=) | `97.354% <100.000%> (+0.014%)` | :arrow_up: | ... and [29 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry). Last update [7bdf989...4c15f4b](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3948?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry).