fix: Unable to find class: SentryCrashExceptionApplication

brustolin commented 3 weeks ago

:scroll: Description

Added a reference SentryCrashExceptionApplication inside the SDK to prevent compiler from stripping it.

:bulb: Motivation and Context

closes #3949

:green_heart: How did you test it?

Sample

:pencil: Checklist

You have to check all boxes before merging:

[x] I reviewed the submitted code.
[x] I added tests to verify the changes.
[x] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
[x] I updated the docs if needed.
[x] Review from the native team if needed.
[x] No breaking change or entry added to the changelog.
[x] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.852%. Comparing base (6ae86f6) to head (2794836).

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3957/graphs/tree.svg?width=650&height=150&src=pr&token=PTZKtOJlrs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) ```diff @@ Coverage Diff @@ ## main #3957 +/- ## ============================================= - Coverage 90.870% 90.852% -0.018% ============================================= Files 594 594 Lines 46080 46080 Branches 16441 16439 -2 ============================================= - Hits 41873 41865 -8 - Misses 4027 4145 +118 + Partials 180 70 -110 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3957?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [Sources/Sentry/SentrySDK.m](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3957?src=pr&el=tree&filepath=Sources%2FSentry%2FSentrySDK.m&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-U291cmNlcy9TZW50cnkvU2VudHJ5U0RLLm0=) | `86.335% <ø> (ø)` | | ... and [32 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3957/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3957?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3957?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry). Last update [6ae86f6...2794836](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3957?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry).

github-actions[bot] commented 2 weeks ago

Performance metrics :rocket:

	Plain	With Sentry	Diff
Startup time	1236.51 ms	1255.65 ms	19.14 ms
Size	21.58 KiB	625.82 KiB	604.24 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
bd2afa60621240d5596fdca06191173dcb6bf982	1241.37 ms	1246.20 ms	4.83 ms
277f226617c23698e1c8a60420f35b5de3663a07	1241.65 ms	1253.74 ms	12.09 ms
15b8c6111854bacf68624e765d99adcf93bfc987	1223.16 ms	1244.83 ms	21.67 ms
6f4d20cfd596b993e8ef9c1ebdeb5c835cb612be	1228.67 ms	1238.88 ms	10.21 ms
b9a9ffd9ab91b555e7b798a60311876a15b87b01	1201.61 ms	1215.06 ms	13.45 ms
51307b7a5ea765a15f05a4a3a770356471d45b2f	1232.22 ms	1235.60 ms	3.38 ms
42ef6baf82435c9e60f92974097657417ca4839a	1230.86 ms	1252.65 ms	21.80 ms
4053ee90b75473db21ccfc2e1f361f22e2d0544c	1248.04 ms	1250.82 ms	2.78 ms
69d2789582b8939b8d9bd40dae84f8c362fcd574	1235.73 ms	1254.00 ms	18.27 ms
e3adcd55356a993e08d5f6db970a604ce0bf837f	1206.47 ms	1215.39 ms	8.92 ms

App size

Revision	Plain	With Sentry	Diff
bd2afa60621240d5596fdca06191173dcb6bf982	20.76 KiB	420.55 KiB	399.79 KiB
277f226617c23698e1c8a60420f35b5de3663a07	22.84 KiB	401.67 KiB	378.83 KiB
15b8c6111854bacf68624e765d99adcf93bfc987	20.76 KiB	419.67 KiB	398.91 KiB
6f4d20cfd596b993e8ef9c1ebdeb5c835cb612be	20.76 KiB	431.71 KiB	410.95 KiB
b9a9ffd9ab91b555e7b798a60311876a15b87b01	21.58 KiB	418.43 KiB	396.85 KiB
51307b7a5ea765a15f05a4a3a770356471d45b2f	22.85 KiB	407.63 KiB	384.78 KiB
42ef6baf82435c9e60f92974097657417ca4839a	21.58 KiB	417.86 KiB	396.28 KiB
4053ee90b75473db21ccfc2e1f361f22e2d0544c	20.76 KiB	435.22 KiB	414.46 KiB
69d2789582b8939b8d9bd40dae84f8c362fcd574	21.58 KiB	548.09 KiB	526.51 KiB
e3adcd55356a993e08d5f6db970a604ce0bf837f	21.58 KiB	539.87 KiB	518.28 KiB

getsentry / sentry-cocoa