search

getsentry / sentry-cocoa

The official Sentry SDK for iOS, tvOS, macOS, watchOS.
https://sentry.io/for/cocoa/
MIT License
773 stars 306 forks source link

ref: FramesTrackingIntegration remove stop #3978

Closed philipphofmann closed 2 weeks ago

philipphofmann commented 2 weeks ago

Remove not needed stop method.

Came up while investigating https://github.com/getsentry/sentry-cocoa/issues/3700.

skip-changelog

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.805%. Comparing base (1ac58a6) to head (8a78a2e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3978/graphs/tree.svg?width=650&height=150&src=pr&token=PTZKtOJlrs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) ```diff @@ Coverage Diff @@ ## main #3978 +/- ## ============================================= - Coverage 90.870% 90.805% -0.066% ============================================= Files 594 594 Lines 46083 46081 -2 Branches 16442 16458 +16 ============================================= - Hits 41876 41844 -32 - Misses 4027 4057 +30 Partials 180 180 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3978?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [Sources/Sentry/SentryFramesTrackingIntegration.m](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3978?src=pr&el=tree&filepath=Sources%2FSentry%2FSentryFramesTrackingIntegration.m&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-U291cmNlcy9TZW50cnkvU2VudHJ5RnJhbWVzVHJhY2tpbmdJbnRlZ3JhdGlvbi5t) | `100.000% <ø> (ø)` | | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3978/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3978?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3978?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry). Last update [1ac58a6...8a78a2e](https://app.codecov.io/gh/getsentry/sentry-cocoa/pull/3978?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry).
github-actions[bot] commented 2 weeks ago

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1218.22 ms 1235.78 ms 17.55 ms
Size 21.58 KiB 626.08 KiB 604.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c02142228d34fd596517f17e64955e2b9a895f28 1199.15 ms 1222.20 ms 23.05 ms
438e21a0191e5a88b109b3663d770bfd1ef51d56 1237.47 ms 1255.24 ms 17.77 ms
ed68562a526ce980aa394b6c4557923e136874a7 1238.45 ms 1251.57 ms 13.12 ms
83887aff6461a3c4738c6852d55faaef69cd1d98 1196.94 ms 1206.82 ms 9.88 ms
965db8acebe39e6a6a1f0367427d7dfd8f8265d9 1211.61 ms 1226.60 ms 14.99 ms
88ca9d87c1abf82b6a3e6b38854b469f91bf956b 1228.09 ms 1254.79 ms 26.70 ms
42ef6baf82435c9e60f92974097657417ca4839a 1234.35 ms 1252.29 ms 17.94 ms
72c8d84c86cebd726dd3b34ab9ff09a3596dd5f2 1266.16 ms 1267.57 ms 1.41 ms
de033daa1cfa7690b0644ba9292b69259d386266 1216.91 ms 1222.84 ms 5.92 ms
7fe37ab504ed30974d73398e7b35fb18e442b508 1236.10 ms 1258.83 ms 22.73 ms

App size

Revision Plain With Sentry Diff
c02142228d34fd596517f17e64955e2b9a895f28 20.76 KiB 435.64 KiB 414.88 KiB
438e21a0191e5a88b109b3663d770bfd1ef51d56 20.76 KiB 434.62 KiB 413.86 KiB
ed68562a526ce980aa394b6c4557923e136874a7 22.84 KiB 403.24 KiB 380.39 KiB
83887aff6461a3c4738c6852d55faaef69cd1d98 21.58 KiB 419.64 KiB 398.06 KiB
965db8acebe39e6a6a1f0367427d7dfd8f8265d9 22.84 KiB 403.24 KiB 380.39 KiB
88ca9d87c1abf82b6a3e6b38854b469f91bf956b 21.58 KiB 612.82 KiB 591.24 KiB
42ef6baf82435c9e60f92974097657417ca4839a 21.58 KiB 417.86 KiB 396.28 KiB
72c8d84c86cebd726dd3b34ab9ff09a3596dd5f2 22.85 KiB 408.88 KiB 386.03 KiB
de033daa1cfa7690b0644ba9292b69259d386266 21.58 KiB 418.15 KiB 396.57 KiB
7fe37ab504ed30974d73398e7b35fb18e442b508 21.58 KiB 542.28 KiB 520.70 KiB