MXCPUException events are incredibly noisy

dfed commented 4 months ago

Platform

iOS

Environment

Production, TestFlight

Installed

Swift Package Manager

Version

8.26.0

Xcode Version

15.4

Did it work on previous versions?

No

Steps to Reproduce

Have MXCPUExceptions thrown in your app – I'm not sure what Sentry flags turn this on or off

Expected Result

MXCPUExceptions on a single page or encountered by a single user within a certain small time period get duplicated into the same issue

Actual Result

When a single user enters a state where their app starts throwing MXCPUException, we get half a dozen issues filed at once. I find myself spending a ton of time going through and duplicating/merging issues. I'm at a point where I want to turn off tracking for this kind of error but I'm not sure which dial to turn.

Are you willing to submit a PR?

No response

brustolin commented 4 months ago

Hello @dfed thanks for reaching out.

The MXCPUException Is triggered by MetricKit, we will work to improve grouping.

In the mean time, if you really wants to disable it:

SentrySDK.start { options in
    //...
    options.enableMetricKit = false
}

kahest commented 4 months ago

@dfed are you on sentry.io and would you be able to share links to the issues you mentioned? You can link them either here or send them to my email karl.struggl@sentry.io

dfed commented 4 months ago

I'm not on sentry.io but I'll forward you links shortly. Apologies for the delay!

dfed commented 4 months ago

@kahest here's a list of these kinds of unique events from yesterday, from a single customer, all fired in the same minute:

This kind of barrage of nearly 20 issues at once for the same underlying cause is typical. Every time a customer of ours ends up in MX*Exception land we get another barrage of unique issues. If you search our project for PortolaApp.$main, you'll find more than 160 of these, and any issue created in the same minute as these is almost certainly a duplicate.

Let me know if I can provide more info!

kahest commented 4 months ago

@dfed Thanks a lot, this is definitely helpful. We'll need to investigate and follow up here. Please be aware that due to conferences and PTOs we're currently a bit slower than usual.

philipphofmann commented 3 months ago

@dfed, the quality of the stacktraces depends on MetricKit. The Cococ SDK takes them and parses them to Sentry events. The problem I see is that most of your MXCPUException events have the same title as Sentry uses the inApp frames to determine the title. Still, issue seems to have a different stacktrace for the root cause. Can you post some examples of issues you merged? I guess if we improved grouping, they would be more actionable. Do you have any suggestions on how you would expect the issues to be grouped?

dfed commented 3 months ago

Apologies for the delay responding! I don't know which issues I've merged at this point.

I just know that without any event grouping the issues filed couldn't be prioritized, and the volume of issues created any time a user entered this exception state meant these alerts were effectively noise.

philipphofmann commented 3 months ago

@dfed, I checked your events again, and I see some top most frames in a package called GameController, that could potentially be inApp, but they aren't. So should these frames be inApp? If yes, maybe you need to add GameController to inAppIncludes or you could change the stacktrace rules in your project, so we mark them as inApp, because then Sentry considers them for grouping.

getsentry / sentry-cocoa