search

getsentry / sentry-cocoa

The official Sentry SDK for iOS, tvOS, macOS, watchOS.
https://sentry.io/for/cocoa/
MIT License
797 stars 314 forks source link

add `shellcheck` precommit hook #4149

Closed armcknight closed 2 weeks ago

armcknight commented 1 month ago

Description

to lint shell scripts

brustolin commented 1 month ago

Our scripts are not part of the product but tools to automate things. Adding lint to them is just an extra unnecessary headache

philipphofmann commented 1 month ago

If ShellCheck improves the quality of our shell scripts our developer workflow should benefit and therefore make us more productive. I think we can give this a shot both as a pre commit hook and CI and see how it goes. We can always ditch it if it's a headache.