search

getsentry / sentry-cocoa

The official Sentry SDK for iOS, tvOS, macOS, watchOS.
https://sentry.io/for/cocoa/
MIT License
808 stars 323 forks source link

Rework upload symbol script #4328

Closed armcknight closed 1 month ago

armcknight commented 2 months ago

Description

We currently require an auth token to be provided, and caution against committing the patch to apply to get the symbol upload script to avoid committing auth tokens to the repo:

This can now be done using environment variables, so we should rework the script and leave it in the build phases. See the script I wrote for the SE iOS demo: https://github.com/sentry-demos/ios/blob/master/upload-symbols.sh

Ideally, we create a new build config for debug builds that upload symbols. This way, we don't upload a large volume from the standard debug config. We can also configure it to always upload for release builds.

This way developers can freely upload symbols as needed with minimal changes to the git working index.

philipphofmann commented 1 month ago

@armcknight, do you use the upload-dsyms-with-xcode-build-phase.sh? I created this some time ago because I regularly upload the dSYMs via Xcode. Nowadays, I always check symbolication via TestFlight and have even forgotten that this script exists. @brustolin also never uses it. My point is if none of us use it, we don't need to improve it, and we can even discuss removing it.

armcknight commented 1 month ago

Yep, that's fair too, we could consider removing it. It's been a long time since I needed something symbolicated for testing while debugging.

philipphofmann commented 1 month ago

Excellent. I removed it: https://github.com/getsentry/sentry-cocoa/pull/4398.