getsentry / sentry-cordova

The official Sentry SDK for Cordova
https://sentry.io/
MIT License
68 stars 55 forks source link

Feat: Sentry Replay #299

Closed lucas-zimerman closed 1 year ago

lucas-zimerman commented 1 year ago

Sentry Replay is bundled with Sentry Cordova, but needs to be manually initialized, for example:

    // Cordova is now initialized. Have fun!
    var Sentry = cordova.require("sentry-cordova.Sentry");
    Sentry.init({
         dsn: 'https://7e4fb5fbc26e4014acb13772e1782aea@o447951.ingest.sentry.io/5627302', 
         debug:true, 
         integrations: [ new Sentry.Replay({
            maskAllText: true,
            blockAllMedia: false,    
         }) ]
    });

Additional changes:

TODO:

lucas-zimerman commented 1 year ago

Sorry for extra lines on build.yml, vscode decided to format that file (not sure if it's correct now or not) At any case will undo it to not pollute this PR.

lucas-zimerman commented 1 year ago

Cool to see this works, but I'm concerned it's so many version behind. If we have bug reports, we can't bump the JS SDK to get the fix?

Cool to see this works, but I'm concerned it's so many version behind. If we have bug reports, we can't bump the JS SDK to get the fix?

About the issue with Replay: https://sentry.io/organizations/sentry-sdks/issues/3899108480/events/ae18a2d6bff74d08904b4284231c49f4/?project=5627302 I can't do a lot about it since it's inside of a private repro but I added a filter to not send this error to the users.

image

Maybe the issue here is that it tried to return the property target but it was not found, so it felt into the catch block that also tried to return the target, resulting on the same error.

NOTE: This error only happens when the main webpage is hidden.

expcapitaldev commented 1 year ago

hi, any updates here?

expcapitaldev commented 1 year ago

@lucas-zimerman sorry I tagged you, can you pls share information about merge?

lucas-zimerman commented 1 year ago

@expcapitaldev We'll update the SDKs first on a new version and then afterwards conclude the Replay feature for Cordova

github-actions[bot] commented 1 year ago

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀