search

getsentry / sentry-cordova

The official Sentry SDK for Cordova
https://sentry.io/
MIT License
68 stars 55 forks source link

Fix release versioning. #306

Closed lucas-zimerman closed 11 months ago

lucas-zimerman commented 1 year ago 
  files: ['./src/ios/SentryCordova.m'

No longer contains the version on the iOS version on the file (SentryCordovaVersionString) since 2021 https://github.com/getsentry/sentry-cordova/pull/204/files#diff-f8a47e25919a891e528e41e9ef8d5d529c792f32c9649b42159bc02db15e76b2L4

Current Regex for updating the version of package.xml is broken and is not updating the release version ( a simple fix like 

id="sentry-cordova" version="\d+\.\d+.\d+.+">

should fix it).

ADDITIONALLY, There should be at least an action to validate that those files that are expected to have a release version defined in code have the correct version defined.

github-actions[bot] commented 1 year ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀