search

getsentry / sentry-dart-plugin

A Dart Build Plugin that uploads debug symbols for Android, iOS/macOS and source maps for Web to Sentry via sentry-cli
MIT License
67 stars 28 forks source link

Don't upload Flutter framework debug symbols #173

Open vaind opened 11 months ago

vaind commented 11 months ago

Now that we've started collecting iOS, macOS and Android debug symbols in https://github.com/getsentry/sentry-dart/pull/1673 we should stop uploading the incomplete symbols that ara available in the local build folder. They're not useful to show any debug information and are just a waste of resources (build time, bandwidth, storage).

denrase commented 6 months ago

@vaind Hey! Do you have a suggestion on how to implement this? AFAIk there is no option in sentry-cli to exclude files/folders ATM

vaind commented 6 months ago

sentry-cli debug-files upload <optional-config-args> filename.so another-file.so ... is the command that uploads just the given files.

Instead of passing a directory, you can explicitly name the files that need to be uploaded. This reduces upload (build) time and saves storage on Sentry servers by not uploading files that are not needed for symbolication.

denrase commented 5 months ago

@vaind Thx for the insight. How would we handle the macOS files expected in the integration test? Can those can be different, depending on what the application uses? Are they also collected outside of users doing the upload for their builds? I'm missing some context here.

https://github.com/getsentry/sentry-dart-plugin/blob/1bea0c7e97be37b9d6203d16f069edd5e2e200e8/integration-test/scripts/test.ps1#L99

vaind commented 5 months ago

Those seem to be standard swift libraries so not part of the Flutter symbol upload cron. Although, being standard libraries I think they should be resolvable from standard symbol servers but better check with some folks from the cocoa SDK.