getsentry / sentry-dart-plugin

A Dart Build Plugin that uploads debug symbols for Android, iOS/macOS and source maps for Web to Sentry via sentry-cli
MIT License
68 stars 28 forks source link

Support configuration arguments via `--sentry-define` #198

Closed denrase closed 7 months ago

denrase commented 9 months ago

:scroll: Description

Tried using Dart Environment Declarations, but failed for several reasons:

denis@Deniss-MBP integration-test % dart run sentry_dart_plugin
The Flutter SDK is not available.

It seems plugins can use the arguments users pass, so I opted to implement our own declarations using a similar syntax:

--sentry-define=<KEY>=<VALUE>

With which users can pass any of our supported keys.

flutter packages pub run sentry_dart_plugin --sentry-define=release=app-internal-test@0.0.1

:bulb: Motivation and Context

Closes #81

:green_heart: How did you test it?

:pencil: Checklist

github-actions[bot] commented 9 months ago
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against eee9ceb630810ad067bb4ebc1e34a9bb07694e6c

eb-so commented 8 months ago

Any new updates on this feature?

denrase commented 8 months ago

@eb-so Sorry for the delay. I updated the PR and now it's ready for review.

eb-so commented 8 months ago

@eb-so Sorry for the delay. I updated the PR and now it's ready for review.

No worries, thanks for the update

denrase commented 8 months ago

@stefanosiano Could you take a look here? 👀

denrase commented 7 months ago

@buenaflor Could you re-review here to check if everything is as expected?

denrase commented 7 months ago

@buenaflor Let's merge the other PR and then update here.

buenaflor commented 7 months ago

Needs updating of the comments as soon as https://github.com/getsentry/sentry-dart-plugin/pull/216 is merged