getsentry / sentry-dart-plugin

A Dart Build Plugin that uploads debug symbols for Android, iOS/macOS and source maps for Web to Sentry via sentry-cli
MIT License
66 stars 28 forks source link

Update env/config `release` and `dist` behaviour #217

Closed denrase closed 7 months ago

denrase commented 7 months ago

:scroll: Description

Default Release

Providing custom release from env. variable or plugin config

Providing custom dist from env. variable or plugin config

Env Variables

:bulb: Motivation and Context

Closes #207

:green_heart: How did you test it?

Unit tests

:pencil: Checklist

github-actions[bot] commented 7 months ago
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against 9e311663127eefd3aa20bb8640fa2b01ae1f2ec0

denrase commented 7 months ago

@stefanosiano Please add your 2 cents here, as this is changing current behaviour. 🙇

buenaflor commented 7 months ago

Since this is breaking, should we consider releasing it as 2.0.0 ?

denrase commented 7 months ago

@buenaflor Added info in readme. This PR points to #216. So when we merge here we can check for 2.0 release. WDYT?

buenaflor commented 7 months ago

@denrase sounds good