Add support for build files folder parameter

getsentry / sentry-dart-plugin

A Dart Build Plugin that uploads debug symbols for Android, iOS/macOS and source maps for Web to Sentry via sentry-cli

MIT License

67 stars 28 forks source link

Add support for build files folder parameter #235

Closed denrase closed 6 months ago

denrase commented 6 months ago

:scroll: Description

Add support for build files folder parameter

:bulb: Motivation and Context

Closes #228

:green_heart: How did you test it?

Unit Tests

:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[ ] I updated the docs if needed
[x] All tests passing
[x] No breaking changes

github-actions[bot] commented 6 months ago

	Messages
:book:	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against 17ff2904275f8fb086a790a22f38a97720d5ef6b

denrase commented 6 months ago

@buenaflor I assumed that web path behaviour would stay the same and users can also specify a custom path there as the need it. Don't think we can assume web path to be correct in relation to a custom build path users provide, no?

buenaflor commented 6 months ago

Don't think we can assume web path to be correct in relation to a custom build path users provide, no?

yeah, was just wondering if it makes sense to call that out somehow but not sure, maybe not?

denrase commented 6 months ago

@buenaflor I changed the naming to match the other parameter and added some context in the readme