search

getsentry / sentry-dart-plugin

A Dart Build Plugin that uploads debug symbols for Android, iOS/macOS and source maps for Web to Sentry via sentry-cli
MIT License
66 stars 29 forks source link

Only upload `.dart` files with `upload-sourcemaps` when `upload_sources` is enabled #247

Closed denrase closed 2 months ago

denrase commented 2 months ago

… is enabled

:scroll: Description

:bulb: Motivation and Context

Relates to #246

:green_heart: How did you test it?

Tests

:pencil: Checklist

denrase commented 2 months ago

@buenaflor Would still be interesting what the reasoning behind having the dart file upload in the first place.

buenaflor commented 2 months ago

Would still be interesting what the reasoning behind having the dart file upload in the first place.

should be the source context, we probably should mention it that it works as well for flutter web.

https://docs.sentry.io/platforms/flutter/upload-debug/#uploading-source-context-for-flutter-android-ios-and-macos doesn't say that it works on web

buenaflor commented 2 months ago

@denrase

This will automatically enable Source Context as well. is under the source maps section

I still think it should be more visible.

Maybe the source context header should be a general header and has subsections based on platform