getsentry / sentry-dart-plugin

A Dart Build Plugin that uploads debug symbols for Android, iOS/macOS and source maps for Web to Sentry via sentry-cli
MIT License
67 stars 28 forks source link

Add `urlPrefix` to sentry configuration #253

Closed denrase closed 3 months ago

denrase commented 3 months ago

:scroll: Description

Add urlPrefix to sentry configuration

:bulb: Motivation and Context

Continuation of #222

:green_heart: How did you test it?

Unit tests

:pencil: Checklist

github-actions[bot] commented 3 months ago
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against e71458e370d68a376c9cdc5b534651374200497b

denrase commented 3 months ago

@buenaflor Building upon the work of JoydS so we can merge this.

JoydS commented 3 months ago

Im sorry but there is a mistake in the documentation

denrase commented 3 months ago

@JoydS Could you point me to the incorrect documentation?

JoydS commented 3 months ago

The example

denrase commented 3 months ago

Sorry for not being more clear, I meant what specifically is wrong in the example?

JoydS commented 3 months ago

It should be "~/app/"m not "https://mysentry.invalid/"

denrase commented 3 months ago

@JoydS Ah yes 🤦 Fixed in #254

lukaszmielczarekdev commented 1 week ago

Can we make a release with this feature?

JoydS commented 1 week ago

It supposes to be realised but it's not working, I don't know why. Everything is still minified on my side.

lukaszmielczarekdev commented 1 week ago

In my opinion it is not, please look at the last release date.

buenaflor commented 1 week ago

hey we will make a release on Monday that will include this

buenaflor commented 4 days ago

release is out in 2.2.0, sorry for the delay

lukaszmielczarekdev commented 3 days ago

Thanks a lot. But it is not working for me, everything is still minified. Can anyone confirm that it works for them?

buenaflor commented 3 days ago

@lukaszmielczarekdev did you follow the guide in the readme regarding also updating your beforeSend?

lukaszmielczarekdev commented 2 days ago

The problem I have is that it doesn't send .dart files to Sentry, it only sends one package with .js files (10 pieces). There should be a second portion, much larger with .dart files. The logs say that it found 10 files first, then 0. In the previous version of the package, all files were sent, and in the latest one only one part.

config

Version 2.2.0 (prefix added)

part

Version 2.1.0

all
buenaflor commented 1 day ago

thanks for the info @lukaszmielczarekdev do you mind opening an issue here in the repo? it's easier for us this way 🙏

lukaszmielczarekdev commented 1 day ago

Yeah, sure. Done 😉