search

getsentry / sentry-dart

Sentry SDK for Dart and Flutter
https://sentry.io/for/flutter/
MIT License
725 stars 223 forks source link

Testflight: build with —obfuscate --split-debug-info flags #2061

Closed denrase closed 3 weeks ago

denrase commented 1 month ago

skip-changelog

:scroll: Description

build with —obfuscate --split-debug-info flags

:bulb: Motivation and Context

Relates to #1983

:pencil: Checklist

denrase commented 1 month ago

@buenaflor Ok, source context does actually work now. We should merge this, as this was missing.

https://sentry-sdks.sentry.io/issues/5349252995/events/0690a879135742fc98aa2e744dadf714/?project=5428562&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=next-event&statsPeriod=14d&stream_index=0

buenaflor commented 1 month ago

Ok, source context does actually work now. We should merge this, as this was missing.

sounds good, how does the grouping look like now?

denrase commented 3 weeks ago

Grouping works if the flags are applied the same for both platforms. https://github.com/getsentry/sentry-dart/issues/1983#issuecomment-2110401362

github-actions[bot] commented 3 weeks ago

Android Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 368.36 ms 440.22 ms 71.86 ms
Size 6.35 MiB 7.33 MiB 1005.63 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e66e71e88df2510c6a9a6fcdbca29d5a59a4fbb9 296.84 ms 345.43 ms 48.59 ms
df16b96fceb6ce836e4d52d33120d7b1d922d5a7 326.08 ms 391.82 ms 65.74 ms
95d0636f4b734360bc5fdbe6f3c53ea2ecc9ee97 301.46 ms 357.98 ms 56.52 ms
3e3389168b45dba147dea4d5fdb53697679d3758 313.60 ms 379.51 ms 65.91 ms
ee0ca56b51107c6e5048fd280474f2c0a1ea5104 355.35 ms 421.13 ms 65.78 ms
3a439051e01626aeb18b40f281823af4f1f1689c 334.12 ms 404.02 ms 69.90 ms
7f75f32d9707c5a5abdb869a9eb5de05dd91bed8 347.36 ms 419.58 ms 72.22 ms
1b663585afa7efcc1a0b17a35e0d20edd78546d5 314.96 ms 363.39 ms 48.43 ms
24b6e601e2c8a3bc70ac06d1d0293067d3df5351 440.64 ms 557.96 ms 117.32 ms
202b83fbe2be04234709a8daf58ea4290ec01cc6 357.79 ms 419.47 ms 61.68 ms

App size

Revision Plain With Sentry Diff
e66e71e88df2510c6a9a6fcdbca29d5a59a4fbb9 6.06 MiB 7.09 MiB 1.03 MiB
df16b96fceb6ce836e4d52d33120d7b1d922d5a7 6.06 MiB 7.03 MiB 988.94 KiB
95d0636f4b734360bc5fdbe6f3c53ea2ecc9ee97 6.16 MiB 7.14 MiB 1007.32 KiB
3e3389168b45dba147dea4d5fdb53697679d3758 6.16 MiB 7.14 MiB 1007.46 KiB
ee0ca56b51107c6e5048fd280474f2c0a1ea5104 6.33 MiB 7.30 MiB 992.52 KiB
3a439051e01626aeb18b40f281823af4f1f1689c 6.06 MiB 7.03 MiB 996.98 KiB
7f75f32d9707c5a5abdb869a9eb5de05dd91bed8 6.26 MiB 7.20 MiB 959.18 KiB
1b663585afa7efcc1a0b17a35e0d20edd78546d5 6.06 MiB 7.09 MiB 1.03 MiB
24b6e601e2c8a3bc70ac06d1d0293067d3df5351 6.33 MiB 7.26 MiB 950.14 KiB
202b83fbe2be04234709a8daf58ea4290ec01cc6 6.34 MiB 7.28 MiB 966.66 KiB
github-actions[bot] commented 3 weeks ago

iOS Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1250.34 ms 1272.98 ms 22.64 ms
Size 8.33 MiB 9.54 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6aab859f42bd361abd466a8fdfb0ddcaf7f8cca4 1245.14 ms 1247.59 ms 2.45 ms
9c5aec6059869d06fd3c0c37f68ef530fb707ceb 1266.51 ms 1274.65 ms 8.14 ms
895beccc1c868667fa23473ba6287d23ed246bc8 1288.00 ms 1308.63 ms 20.63 ms
24b6e601e2c8a3bc70ac06d1d0293067d3df5351 1250.69 ms 1268.63 ms 17.94 ms
8d6437613cd26d4c43d081a1ba02f4a726339037 1260.92 ms 1289.32 ms 28.40 ms
eb1a7c1075248085a3da029c96da78223902b131 1281.25 ms 1295.40 ms 14.15 ms
8cb65572208ec7aa2e324de7cc642ae3104da349 1265.14 ms 1266.08 ms 0.94 ms
f0fcbe1432e5c9ffab835fe700c5c061fb52aa98 1238.08 ms 1243.44 ms 5.36 ms
d189e0173d59fd57d046fc13e20bf6842ab2f236 1219.94 ms 1228.20 ms 8.27 ms
559d28f4fd4a5379a6776683dbadfec93ffb5635 1265.04 ms 1288.96 ms 23.92 ms

App size

Revision Plain With Sentry Diff
6aab859f42bd361abd466a8fdfb0ddcaf7f8cca4 8.29 MiB 9.36 MiB 1.07 MiB
9c5aec6059869d06fd3c0c37f68ef530fb707ceb 8.15 MiB 9.12 MiB 986.23 KiB
895beccc1c868667fa23473ba6287d23ed246bc8 8.10 MiB 9.18 MiB 1.08 MiB
24b6e601e2c8a3bc70ac06d1d0293067d3df5351 8.32 MiB 9.38 MiB 1.06 MiB
8d6437613cd26d4c43d081a1ba02f4a726339037 8.16 MiB 9.17 MiB 1.01 MiB
eb1a7c1075248085a3da029c96da78223902b131 8.15 MiB 9.13 MiB 1000.10 KiB
8cb65572208ec7aa2e324de7cc642ae3104da349 8.10 MiB 9.18 MiB 1.08 MiB
f0fcbe1432e5c9ffab835fe700c5c061fb52aa98 8.29 MiB 9.38 MiB 1.09 MiB
d189e0173d59fd57d046fc13e20bf6842ab2f236 8.29 MiB 9.38 MiB 1.09 MiB
559d28f4fd4a5379a6776683dbadfec93ffb5635 8.15 MiB 9.12 MiB 987.32 KiB