search

getsentry / sentry-dart

Sentry SDK for Dart and Flutter
https://sentry.io/for/flutter/
MIT License
745 stars 231 forks source link

feat: associate dart errors with replays #2070

Closed vaind closed 3 months ago

vaind commented 3 months ago

part of #2032 so #skip-changelog

Result after this PR

TODO

github-actions[bot] commented 3 months ago
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against bc157ab0b7344353c4aec21bfb0922228756de93

vaind commented 3 months ago

@buenaflor you've already reviewed the main replay PR so I've created this change as a separate one, so that it's easier to review. Please let me know if the changes are OK in general (because I'm not so sure around these areas of the code) and I'll update tests afterwards.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 92.50%. Comparing base (a93da0b) to head (bc157ab).

Files Patch % Lines
...lutter/lib/src/native/java/sentry_native_java.dart 0.00% 5 Missing :warning:
...ib/src/event_processor/replay_event_processor.dart 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/android-replay #2070 +/- ## ======================================================= - Coverage 92.69% 92.50% -0.19% ======================================================= Files 60 60 Lines 1970 1974 +4 ======================================================= Hits 1826 1826 - Misses 144 148 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

buenaflor commented 3 months ago

fyi, the sqflite analyze ci failure is not related to this PR

vaind commented 3 months ago

I'll update tests afterwards.

I've added the tests now