getsentry / sentry-dart

Sentry SDK for Dart and Flutter
https://sentry.io/for/flutter/
MIT License
725 stars 223 forks source link

ref: Add getCurrentStackTrace #2072

Closed philipphofmann closed 4 weeks ago

philipphofmann commented 4 weeks ago

:scroll: Description

Add the wrapper method getCurrentStackTrace so the SDK crash detection can ignore it.

skip-changelog

:bulb: Motivation and Context

For https://github.com/getsentry/sentry/pull/71545.

:green_heart: How did you test it?

Unit tests are still green.

:pencil: Checklist

:crystal_ball: Next steps

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.30%. Comparing base (b8562d0) to head (481a492).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2072 +/- ## ======================================= Coverage 95.30% 95.30% ======================================= Files 54 54 Lines 1789 1789 ======================================= Hits 1705 1705 Misses 84 84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 weeks ago

Android Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 376.35 ms 454.51 ms 78.16 ms
Size 6.35 MiB 7.33 MiB 1005.54 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
117d988b347861588d574fcc789ecbb4f7c8bdb5 376.32 ms 450.85 ms 74.53 ms
2d3b03d17e0b28a698d4de81ab6ac6b586c4533a 309.53 ms 353.40 ms 43.87 ms
29297d43a910bfd6a6932ecb456e70aac411508a 377.14 ms 451.54 ms 74.40 ms
9fe67d51d3fe8a8daa73206ae4eac77ca507e406 373.80 ms 444.24 ms 70.45 ms
f7f46dc24bc7be39f41415b8c36a927ed3e37cb8 306.38 ms 363.32 ms 56.95 ms
cd16818c9a52b00812b5354203d617d4294a83f5 316.57 ms 375.19 ms 58.62 ms
6078ddcf85799bf45a037f579fcaa919528483a1 385.72 ms 463.61 ms 77.89 ms
294b7f0b0c5d5a0bef2ba1f491d4a41ef1c5704e 367.83 ms 430.00 ms 62.17 ms
1a938255a9c0a1073ccebbdb23a70ea2d435013e 347.31 ms 424.54 ms 77.23 ms
78eeed5b9772f2cd873401dd922274703ba656c9 298.35 ms 361.63 ms 63.28 ms

App size

Revision Plain With Sentry Diff
117d988b347861588d574fcc789ecbb4f7c8bdb5 6.33 MiB 7.26 MiB 947.03 KiB
2d3b03d17e0b28a698d4de81ab6ac6b586c4533a 6.06 MiB 7.09 MiB 1.03 MiB
29297d43a910bfd6a6932ecb456e70aac411508a 6.34 MiB 7.28 MiB 967.79 KiB
9fe67d51d3fe8a8daa73206ae4eac77ca507e406 6.33 MiB 7.29 MiB 987.27 KiB
f7f46dc24bc7be39f41415b8c36a927ed3e37cb8 6.06 MiB 7.03 MiB 993.54 KiB
cd16818c9a52b00812b5354203d617d4294a83f5 6.26 MiB 7.20 MiB 956.08 KiB
6078ddcf85799bf45a037f579fcaa919528483a1 6.34 MiB 7.29 MiB 967.80 KiB
294b7f0b0c5d5a0bef2ba1f491d4a41ef1c5704e 6.33 MiB 7.26 MiB 950.21 KiB
1a938255a9c0a1073ccebbdb23a70ea2d435013e 6.27 MiB 7.20 MiB 956.36 KiB
78eeed5b9772f2cd873401dd922274703ba656c9 6.16 MiB 7.14 MiB 1009.97 KiB
github-actions[bot] commented 4 weeks ago

iOS Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1246.31 ms 1262.94 ms 16.62 ms
Size 8.33 MiB 9.54 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7748b7cce475ff9e094eafe66ba7e3850ef59f99 1219.04 ms 1237.92 ms 18.88 ms
f83bc1d235973d25cb628df973083f4093ed5282 1247.12 ms 1249.78 ms 2.65 ms
e893df57266c8bbe00cb0e1dfcc876875fc4debe 1247.90 ms 1262.31 ms 14.41 ms
014c3ea4cf506cccc5cfd0eceb6e9b1c1b5fdce9 1298.73 ms 1351.24 ms 52.51 ms
a775d3f6e29f81d61095ff492a0b623ba3ada57e 1241.29 ms 1241.53 ms 0.24 ms
c3e6c820747f2dbb4515a2ed1dcb362eeba83072 1256.93 ms 1276.17 ms 19.24 ms
5cc82a0b7b216bac12872cd053b144a41afe2133 1209.24 ms 1226.31 ms 17.06 ms
6d317ea0c2dcfba0d8300bc7693d2dc292486d01 1277.27 ms 1287.47 ms 10.20 ms
4b5a4f6a2eb127d509b6927bbe9ff4220a3b5289 1245.28 ms 1272.27 ms 26.99 ms
464b4d0afb863838e76307d3ea26f9d46df912ee 1249.02 ms 1261.22 ms 12.20 ms

App size

Revision Plain With Sentry Diff
7748b7cce475ff9e094eafe66ba7e3850ef59f99 8.28 MiB 9.34 MiB 1.06 MiB
f83bc1d235973d25cb628df973083f4093ed5282 8.28 MiB 9.34 MiB 1.05 MiB
e893df57266c8bbe00cb0e1dfcc876875fc4debe 8.09 MiB 9.07 MiB 1001.04 KiB
014c3ea4cf506cccc5cfd0eceb6e9b1c1b5fdce9 8.33 MiB 9.39 MiB 1.06 MiB
a775d3f6e29f81d61095ff492a0b623ba3ada57e 8.28 MiB 9.34 MiB 1.06 MiB
c3e6c820747f2dbb4515a2ed1dcb362eeba83072 8.32 MiB 9.38 MiB 1.06 MiB
5cc82a0b7b216bac12872cd053b144a41afe2133 8.33 MiB 9.40 MiB 1.07 MiB
6d317ea0c2dcfba0d8300bc7693d2dc292486d01 8.15 MiB 9.12 MiB 986.26 KiB
4b5a4f6a2eb127d509b6927bbe9ff4220a3b5289 8.32 MiB 9.39 MiB 1.07 MiB
464b4d0afb863838e76307d3ea26f9d46df912ee 8.10 MiB 9.16 MiB 1.07 MiB
philipphofmann commented 4 weeks ago

@buenaflor, how do I fix the failing CI job https://github.com/getsentry/sentry-dart/actions/runs/9264807763/job/25485604253?pr=2072?

CleanShot 2024-05-28 at 09 14 47@2x

buenaflor commented 4 weeks ago

This seems to be an issue with the main branch, I'll fix that in another PR