search

getsentry / sentry-dart

Sentry SDK for Dart and Flutter
https://sentry.io/for/flutter/
MIT License
745 stars 231 forks source link

Add `ignored` discard reason for client reports #2204

Closed buenaflor closed 1 month ago

buenaflor commented 1 month ago

:scroll: Description

Adds discard reason ignored

:bulb: Motivation and Context

Used for ignoreError and ignoreTransaction later on

skip-changelog

github-actions[bot] commented 1 month ago
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against c84f791ef750c771b34f27d6a457c06c9de6dc87

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (ffa37ac) to head (c84f791).

Files Patch % Lines
dart/lib/src/client_reports/discarded_event.dart 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2204 +/- ## ========================================== + Coverage 88.23% 88.30% +0.06% ========================================== Files 230 230 Lines 7898 7899 +1 ========================================== + Hits 6969 6975 +6 + Misses 929 924 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Android Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 372.70 ms 464.16 ms 91.46 ms
Size 6.35 MiB 7.41 MiB 1.05 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b8562d01376a7efe9af802ab0abd9d8226eb4bd7 362.31 ms 437.27 ms 74.96 ms
6a5a65d1390ef72425d385815fbfb4c1b03ced8d 410.26 ms 503.91 ms 93.65 ms
636cb61552ee37d8206f06e518009b036a877f24 366.59 ms 448.14 ms 81.55 ms
8cb65572208ec7aa2e324de7cc642ae3104da349 321.20 ms 370.46 ms 49.26 ms
8f88a49d613434f898cd280880fbd122370dfffa 364.98 ms 413.78 ms 48.80 ms
dd76eef96d93031410fb154fb4bd51b57d36854b 461.37 ms 540.55 ms 79.18 ms
1c6eb5b33483c440c18525f0e946a9031d09863c 350.69 ms 393.86 ms 43.17 ms
e4d5aa8c2d59f501c1b158b4236384eadc0b7f4b 375.28 ms 443.27 ms 67.99 ms
d0476e172bfbd420473641831f4a4312f630f141 412.20 ms 492.62 ms 80.42 ms
aed5947e87efc02f38e9beb6572e24bd1fed7000 295.70 ms 348.18 ms 52.48 ms

App size

Revision Plain With Sentry Diff
b8562d01376a7efe9af802ab0abd9d8226eb4bd7 6.35 MiB 7.33 MiB 1005.53 KiB
6a5a65d1390ef72425d385815fbfb4c1b03ced8d 6.35 MiB 7.41 MiB 1.05 MiB
636cb61552ee37d8206f06e518009b036a877f24 6.27 MiB 7.20 MiB 959.08 KiB
8cb65572208ec7aa2e324de7cc642ae3104da349 6.06 MiB 7.03 MiB 997.01 KiB
8f88a49d613434f898cd280880fbd122370dfffa 6.34 MiB 7.30 MiB 979.60 KiB
dd76eef96d93031410fb154fb4bd51b57d36854b 6.35 MiB 7.40 MiB 1.05 MiB
1c6eb5b33483c440c18525f0e946a9031d09863c 5.94 MiB 6.92 MiB 1001.53 KiB
e4d5aa8c2d59f501c1b158b4236384eadc0b7f4b 6.35 MiB 7.35 MiB 1017.84 KiB
d0476e172bfbd420473641831f4a4312f630f141 6.35 MiB 7.40 MiB 1.05 MiB
aed5947e87efc02f38e9beb6572e24bd1fed7000 5.94 MiB 6.96 MiB 1.02 MiB
github-actions[bot] commented 1 month ago

iOS Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1248.04 ms 1269.28 ms 21.24 ms
Size 8.34 MiB 9.65 MiB 1.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
df16b96fceb6ce836e4d52d33120d7b1d922d5a7 1255.24 ms 1259.40 ms 4.16 ms
0a82a1ee1ab16b08941011233f534636569d7543 1233.56 ms 1244.56 ms 11.00 ms
abcdba32324a0963ec44af1537d4444dac1699d3 1257.31 ms 1283.49 ms 26.18 ms
6fedcab9f494397bd4e1d450b5423f074c63fd82 1242.33 ms 1269.66 ms 27.33 ms
559d28f4fd4a5379a6776683dbadfec93ffb5635 1265.04 ms 1288.96 ms 23.92 ms
5f443ded4b165e2ece43e774c26e16e1eb5f0b97 1253.37 ms 1277.31 ms 23.95 ms
4efee31c65f1fefbb85fc97598de6b3ae8fd93b4 1270.33 ms 1285.75 ms 15.42 ms
6a5a65d1390ef72425d385815fbfb4c1b03ced8d 1237.22 ms 1250.29 ms 13.07 ms
9c5aec6059869d06fd3c0c37f68ef530fb707ceb 1266.51 ms 1274.65 ms 8.14 ms
eb1a7c1075248085a3da029c96da78223902b131 1281.25 ms 1295.40 ms 14.15 ms

App size

Revision Plain With Sentry Diff
df16b96fceb6ce836e4d52d33120d7b1d922d5a7 8.10 MiB 9.16 MiB 1.06 MiB
0a82a1ee1ab16b08941011233f534636569d7543 8.29 MiB 9.37 MiB 1.08 MiB
abcdba32324a0963ec44af1537d4444dac1699d3 8.15 MiB 9.12 MiB 989.76 KiB
6fedcab9f494397bd4e1d450b5423f074c63fd82 8.32 MiB 9.50 MiB 1.18 MiB
559d28f4fd4a5379a6776683dbadfec93ffb5635 8.15 MiB 9.12 MiB 987.32 KiB
5f443ded4b165e2ece43e774c26e16e1eb5f0b97 8.33 MiB 9.58 MiB 1.25 MiB
4efee31c65f1fefbb85fc97598de6b3ae8fd93b4 8.15 MiB 9.12 MiB 991.35 KiB
6a5a65d1390ef72425d385815fbfb4c1b03ced8d 8.34 MiB 9.65 MiB 1.31 MiB
9c5aec6059869d06fd3c0c37f68ef530fb707ceb 8.15 MiB 9.12 MiB 986.23 KiB
eb1a7c1075248085a3da029c96da78223902b131 8.15 MiB 9.13 MiB 1000.10 KiB