getsentry / sentry-dart

Sentry SDK for Dart and Flutter
https://sentry.io/for/flutter/
MIT License
761 stars 239 forks source link

Events are sent to Sentry even though Spotlight is enabled #2224

Closed Peetee06 closed 3 months ago

Peetee06 commented 3 months ago

Platform

Flutter Mobile

Obfuscation

Disabled

Debug Info

Disabled

Doctor

[✓] Flutter (Channel stable, 3.22.1, on macOS 14.5 23F79 darwin-arm64, locale en-DE)
    • Flutter version 3.22.1 on channel stable at /Users/petertrost/fvm/versions/3.22.1
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (3 months ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/petertrost/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/petertrost/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.92.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (6 available)            
    • sdk gphone arm64 (mobile)       • emulator-5554                        • android-arm64  •
      Android 11 (API 30) (emulator)
    • iPhone 11 von Peter (mobile)    • 00008030-00096D8E3EDB802E            • ios            • iOS
      17.5.1 21F90
    • iPhone 15 (mobile)              • 47ECCBE8-FD97-43C9-80AA-A0A0F858FB1A • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   •
      macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         •
      macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript •
      Google Chrome 127.0.6533.100

[✓] Network resources
    • All expected network resources are available.

• No issues found

Version

8.5.0

Steps to Reproduce

  1. Add ..spotlight = Spotlight(enabled: kDebugMode) to the Sentry options in an app using Sentry
  2. Start the app in debug mode and force an error that gets sent to Sentry

Expected Result

The event is only shown locally in Spotlight but not on sentry.io

Actual Result

The event is shown both in Spotlight AND sentry.io

Are you willing to submit a PR?

Yes

buenaflor commented 3 months ago

Could you verify that again? maybe your sample rate is low

I just tried it locally and it works fine

ueman commented 3 months ago

I read this issue as it's the same issue as in https://github.com/getsentry/sentry-dart/issues/2213

buenaflor commented 3 months ago

oh sorry yeah indeed, my bad

@Peetee06 pls upvote the linked issue: https://github.com/getsentry/sentry-dart/issues/2213

I'll close this one as a duplicate