getsentry / sentry-dart

Sentry SDK for Dart and Flutter
https://sentry.io/for/flutter/
MIT License
754 stars 237 forks source link

Support allowUrls, denyUrls #2227

Closed martinhaintz closed 2 months ago

martinhaintz commented 3 months ago

:scroll: Description

Add allowUrls and denyUrls parameter to the options on the web platform. the user can now specify on which urls, events should be ignored.

:bulb: Motivation and Context

Close #626

:green_heart: How did you test it?

unittest

:pencil: Checklist

:crystal_ball: Next steps

github-actions[bot] commented 3 months ago
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against e5a3315b2818e85836636124396ed2bfe168ed65

github-actions[bot] commented 2 months ago

iOS Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1242.47 ms 1263.29 ms 20.82 ms
Size 8.38 MiB 9.73 MiB 1.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8a10ab719072f65d029985c211471d779ab2a3cb 1226.49 ms 1250.52 ms 24.03 ms
3e4b523ae6cdbc1bc64e9e170cf2ac79bae2f4f4 1260.53 ms 1270.06 ms 9.53 ms
48e79fda4c32b19d5fcb1128713442ed89b33712 1282.96 ms 1296.12 ms 13.17 ms
be08ed1118c3890fabac3197bcc4e9650145c8a8 1247.12 ms 1272.19 ms 25.07 ms
33d0587b190ef0de4ccf9e1e0f2623ffaa76cd2a 1262.16 ms 1270.50 ms 8.34 ms
daa1b330099908feace526008680693a69587afc 1224.41 ms 1244.59 ms 20.18 ms
22ed6cbd073b8533f884fc1240d0c68a096d4efb 1277.41 ms 1283.76 ms 6.35 ms
6034b0a5af03e6891b1153ba6a88f095cbd7a948 1244.89 ms 1270.22 ms 25.33 ms
0aaa46e1517a02ba971b15ecbe7960f6045279a1 1256.39 ms 1276.41 ms 20.02 ms
d8519f962da363304b642a362b6d7d378877e71b 1208.57 ms 1229.80 ms 21.22 ms

App size

Revision Plain With Sentry Diff
8a10ab719072f65d029985c211471d779ab2a3cb 8.28 MiB 9.34 MiB 1.06 MiB
3e4b523ae6cdbc1bc64e9e170cf2ac79bae2f4f4 8.28 MiB 9.33 MiB 1.05 MiB
48e79fda4c32b19d5fcb1128713442ed89b33712 8.16 MiB 9.15 MiB 1021.87 KiB
be08ed1118c3890fabac3197bcc4e9650145c8a8 8.32 MiB 9.38 MiB 1.06 MiB
33d0587b190ef0de4ccf9e1e0f2623ffaa76cd2a 8.29 MiB 9.38 MiB 1.09 MiB
daa1b330099908feace526008680693a69587afc 8.28 MiB 9.34 MiB 1.05 MiB
22ed6cbd073b8533f884fc1240d0c68a096d4efb 8.10 MiB 9.17 MiB 1.08 MiB
6034b0a5af03e6891b1153ba6a88f095cbd7a948 8.33 MiB 9.40 MiB 1.07 MiB
0aaa46e1517a02ba971b15ecbe7960f6045279a1 8.29 MiB 9.38 MiB 1.09 MiB
d8519f962da363304b642a362b6d7d378877e71b 8.32 MiB 9.38 MiB 1.05 MiB

Previous results on branch: feat/support-allow-urls-deny-urls

Startup times

Revision Plain With Sentry Diff
5598f4c0aafa16df27b6959927c526162422a2b0 1246.48 ms 1269.82 ms 23.34 ms
a4c0d5907f568de9b1b860947ce14de85ea2767a 1241.98 ms 1264.47 ms 22.49 ms
8523a6d00d1cf3c74bda1c38864e90628cc4d3ee 1260.88 ms 1284.26 ms 23.38 ms
1ec723587af2584fd081711a41de7c0fc0229968 1239.10 ms 1255.81 ms 16.71 ms
5e7ccc1fa3b0b9d5a7c39426afd02ca3b72a690f 1242.98 ms 1260.53 ms 17.55 ms

App size

Revision Plain With Sentry Diff
5598f4c0aafa16df27b6959927c526162422a2b0 8.38 MiB 9.71 MiB 1.33 MiB
a4c0d5907f568de9b1b860947ce14de85ea2767a 8.38 MiB 9.71 MiB 1.33 MiB
8523a6d00d1cf3c74bda1c38864e90628cc4d3ee 8.38 MiB 9.71 MiB 1.33 MiB
1ec723587af2584fd081711a41de7c0fc0229968 8.38 MiB 9.71 MiB 1.33 MiB
5e7ccc1fa3b0b9d5a7c39426afd02ca3b72a690f 8.38 MiB 9.71 MiB 1.33 MiB
martinhaintz commented 2 months ago

Docs updated here: 11067

github-actions[bot] commented 2 months ago

Android Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 500.57 ms 564.15 ms 63.57 ms
Size 6.52 MiB 7.61 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2261c15342b55a1566de274be3688b1e34743749 370.00 ms 455.88 ms 85.88 ms
eecbbcabbbe00a5dcc7d42cd6334f771a20b547f 324.37 ms 352.49 ms 28.12 ms
f2db4ece59961760d0017bb7b0592fc561ab79f0 372.46 ms 469.72 ms 97.26 ms
c19bfb614d91ae0bceb16bcdfdcef89a82ba6c71 382.00 ms 454.62 ms 72.62 ms
03e4c9b6af66673bdc361ac0231ab682c8d374fe 410.34 ms 493.20 ms 82.86 ms
5e7abc5157b9e43973db9bc8e2a883d69d3fe136 360.82 ms 401.18 ms 40.37 ms
8ced2dc3a0ab7c8f70f4a0f0449ce528b924b96f 295.58 ms 336.49 ms 40.91 ms
b2cbbc84b2f678fc917653a40dd14335ee16b9c2 347.80 ms 395.31 ms 47.51 ms
955541a50762f04c301c83eb25aef0077742c29a 360.53 ms 452.10 ms 91.57 ms
d301b11cc3648dfbc2586cb3c24330063780adf3 337.96 ms 395.04 ms 57.08 ms

App size

Revision Plain With Sentry Diff
2261c15342b55a1566de274be3688b1e34743749 6.27 MiB 7.20 MiB 957.75 KiB
eecbbcabbbe00a5dcc7d42cd6334f771a20b547f 5.94 MiB 6.89 MiB 975.78 KiB
f2db4ece59961760d0017bb7b0592fc561ab79f0 6.06 MiB 7.03 MiB 990.27 KiB
c19bfb614d91ae0bceb16bcdfdcef89a82ba6c71 6.35 MiB 7.41 MiB 1.05 MiB
03e4c9b6af66673bdc361ac0231ab682c8d374fe 6.35 MiB 7.42 MiB 1.07 MiB
5e7abc5157b9e43973db9bc8e2a883d69d3fe136 6.34 MiB 7.28 MiB 966.66 KiB
8ced2dc3a0ab7c8f70f4a0f0449ce528b924b96f 6.06 MiB 7.03 MiB 990.29 KiB
b2cbbc84b2f678fc917653a40dd14335ee16b9c2 6.06 MiB 7.03 MiB 995.45 KiB
955541a50762f04c301c83eb25aef0077742c29a 6.27 MiB 7.20 MiB 957.75 KiB
d301b11cc3648dfbc2586cb3c24330063780adf3 6.06 MiB 7.09 MiB 1.03 MiB

Previous results on branch: feat/support-allow-urls-deny-urls

Startup times

Revision Plain With Sentry Diff
1ec723587af2584fd081711a41de7c0fc0229968 487.81 ms 582.18 ms 94.37 ms
5e7ccc1fa3b0b9d5a7c39426afd02ca3b72a690f 473.86 ms 569.30 ms 95.44 ms
5598f4c0aafa16df27b6959927c526162422a2b0 422.39 ms 466.30 ms 43.91 ms
8523a6d00d1cf3c74bda1c38864e90628cc4d3ee 415.31 ms 464.65 ms 49.33 ms
a4c0d5907f568de9b1b860947ce14de85ea2767a 449.96 ms 487.63 ms 37.67 ms

App size

Revision Plain With Sentry Diff
1ec723587af2584fd081711a41de7c0fc0229968 6.52 MiB 7.59 MiB 1.06 MiB
5e7ccc1fa3b0b9d5a7c39426afd02ca3b72a690f 6.52 MiB 7.59 MiB 1.06 MiB
5598f4c0aafa16df27b6959927c526162422a2b0 6.52 MiB 7.59 MiB 1.06 MiB
8523a6d00d1cf3c74bda1c38864e90628cc4d3ee 6.52 MiB 7.59 MiB 1.06 MiB
a4c0d5907f568de9b1b860947ce14de85ea2767a 6.52 MiB 7.59 MiB 1.06 MiB
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.16%. Comparing base (3356741) to head (e5a3315). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2227 +/- ## ======================================= Coverage 88.15% 88.16% ======================================= Files 242 245 +3 Lines 8416 8422 +6 ======================================= + Hits 7419 7425 +6 Misses 997 997 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vaind commented 2 months ago

analyzer seems to have started failing with this PR

martinhaintz commented 2 months ago

@vaind thanks for the hint. I will fix it in the next hour.