getsentry / sentry-docs

Sentry's documentation (and tools to build it)
https://docs.sentry.io
Other
326 stars 1.39k forks source link

Setting the text highlight colour to transparent breaks accessibility #10320

Open whitep4nth3r opened 1 month ago

whitep4nth3r commented 1 month ago

Steps to Reproduce

  1. Attempt to highlight some text (copy text, not code samples) on the docs page
  2. Observe that you can't see what text you have highlighted
  3. This is due to the webkit-tap-highlight colour being set to transparent

Expected Result

I should be able to see what text I have highlighted if I have done so.

Actual Result

image

Additional Info

No response

getsantry[bot] commented 1 month ago

Assigning to @getsentry/support for routing ⏲️

a-hariti commented 1 month ago

Does this happen on iOS @whitep4nth3r ?

whitep4nth3r commented 1 month ago

This is happening for me on MacOS in Arc browser.

I can highlight correctly on iOS.

a-hariti commented 1 month ago

I'm not sure I understand / can repro the issue @whitep4nth3r screenshot with Arc on Mac os (both in desktop and mobile mode)

image

whitep4nth3r commented 1 month ago

That's strange. I've turned off all my browser extensions and I still can't highlight text.

I've tried in Safari and I can highlight in that browser, so it's not to do with my system settings.

I'm on Arc Version 1.46.0 (50665).

a-hariti commented 1 month ago

I'm on the exact same version

danielcompton commented 4 weeks ago

I can reproduce this in Safari on https://docs.sentry.io/platforms/javascript/guides/express/ on the instrument.js sample, only when logged in.

whitep4nth3r commented 3 weeks ago

I'm now on the following version of Arc on desktop:

Version 1.48.2 (51225)
Chromium Engine Version 126.0.6478.115

And I can highlight text when logged in and when logged out.

I'm not sure what's happening here!

However, regarding logged in/logged out behaviour and I think I found a different bug.

Should the nav bar item for "sign in" change to something else when you are signed in?