Add Profile to Transaction - Githubissues

getsentry / sentry-docs

Sentry's documentation (and tools to build it)

https://docs.sentry.io

Other

336 stars 1.47k forks source link

Add Profile to Transaction #11114

Open thinkocapo opened 3 months ago

thinkocapo commented 3 months ago

Core or SDK?

Core Sentry product

Which part? Which one?

Add Profile to Custom Transaction

Description

Need it for Android but probably a good idea for all SDK's.

We have Android's documentation for Custom Instrumentation we have:

Add More Spans to the Transaction
Create Transaction Bound to The Current Scope
Connect Errors with Spans So how about for
Add Profile to the Custom Transaction :)

Overall Approach:

start a custom transaction [docs say transaction, not span]
[profile will start being recorded for this transaction? :point_up:]
[must create a 'profile' obj, do profile.start() and attach it to the transaction obj? How?]
end the custom transaction [and this will auto-finish the open profile?]

Suggested Solution

Overall Approach:

start a custom transaction [docs say transaction, not span]
profile starts being recorded (assuming they have SDK Profiling enabled)
end the custom transaction and this ends the profile

Can open the Trace/Transaction in Sentry and then view the profile. It should cover the same duration of the parent span (the transaction).

getsantry[bot] commented 3 months ago

Assigning to @getsentry/support for routing ⏲️