Removed metrics documentation for .NET

getsentry / sentry-docs

Sentry's documentation (and tools to build it)

https://docs.sentry.io

Other

333 stars 1.47k forks source link

Removed metrics documentation for .NET #11880

Open jamescrosswell opened 2 days ago

jamescrosswell commented 2 days ago

DESCRIBE YOUR PR

Removing Metrics documentation now this feature has been deprecated

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

[ x ] None: Not urgent, can wait up to 1 week+

SLA

Teamwork makes the dream work, so please add a reviewer to your PRs.

@bruno-garcia you're the only person that I can assign as a reviewer on this sorry... I can't select Bryce in this repo.

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

[ ] Checked Vercel preview for correctness, including links
[ ] PR was reviewed and approved by any necessary SMEs (subject matter experts)
[ ] PR was reviewed and approved by a member of the Sentry docs team

vercel[bot] commented 2 days ago

@jamescrosswell is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

jamescrosswell commented 2 days ago

I see, the linting error implies this can't be removed for .NET in isolation (it would need to be removed for all the other platforms as well presumably?):

❌ Found 1 404 across 1 page

🌐 http://localhost:3000/product/explore/metrics/metrics-set-up
    - [.NET](/platforms/dotnet/metrics/)

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sentry-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 5:58pm

2 Skipped Deployments

coolguyzone commented 1 day ago

@bitsandfoxes can you take a look?

bitsandfoxes commented 1 day ago

We can also remove the reference to the deleted page here https://github.com/getsentry/sentry-docs/blob/10cd1e76c27538315259cb3240274755b1268948/docs/product/explore/metrics/metrics-set-up.mdx?plain=1#L17

jamescrosswell commented 17 hours ago

We can also remove the reference to the deleted page here

https://github.com/getsentry/sentry-docs/blob/10cd1e76c27538315259cb3240274755b1268948/docs/product/explore/metrics/metrics-set-up.mdx?plain=1#L17

Yeah I assumed that was the language agnostic docs though so would affect all the SDKs (not just the .NET SDK)... and I didn't want to mess with that.

bitsandfoxes commented 2 hours ago

I think it's fine to remove the entry on the product page as it links specifically to the page that' getting removed.