getsentry / sentry-docs

Sentry's documentation (and tools to build it)
https://docs.sentry.io
Other
333 stars 1.47k forks source link

Remove Java SDK metrics docs #11884

Closed adinauer closed 1 day ago

adinauer commented 2 days ago

Removes metrics docs as metrics API has been removed in Java SDK v8.

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

SLA

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:47am
2 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **changelog** | ⬜️ Ignored ([Inspect](https://vercel.com/sentry/changelog/4LfbkoW3moNWxKdD4z35iXr5AtWb)) | | | Nov 20, 2024 10:47am | | **develop-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/sentry/develop-docs/TiPFZkXRdGrkBrr9xLYmj7SpU185)) | | | Nov 20, 2024 10:47am |
codecov[bot] commented 2 days ago

Bundle Report

Changes will decrease total bundle size by 342 bytes (-0.0%) :arrow_down:. This is within the configured threshold :white_check_mark:

Detailed changes | Bundle name | Size | Change | | ----------- | ---- | ------ | | sentry-docs-server-cjs | 8.6MB | 342 bytes (-0.0%) :arrow_down: |
coolguyzone commented 1 day ago

Hi @adinauer , I think we need to add some redirects here as these pages are being indexed by google and there may be some other external links out there. Do you know where you'd like these pages to redirect to? If you're comfortable with it, you can add the redirects to this PR yourself, here's a pretty straightforward example: https://github.com/getsentry/sentry-docs/pull/11861/files

Otherwise we can add the redirects, just let me know where to point them. Thanks!

adinauer commented 1 day ago

Thanks, I'll try to find out, where we want to redirect to.

adinauer commented 1 day ago

Talked to the team and there's a link to https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Metrics-Beta-Ended-on-October-7th on the python docs. That page explains why we ended the metrics beta.

I'll update the PR to include the redirect.

adinauer commented 1 day ago

I just talked to @stephanie-anderson and we decided we're gonna keep things as they are. The metrics pages are hidden in the sidebar and there's a disclaimer on top linking to the zendesk page above in case someone still visits the pages. I'm closing this PR.