search

getsentry / sentry-dotnet-ef

Moved to: https://github.com/getsentry/sentry-dotnet
MIT License
7 stars 6 forks source link

Entity Framework Classic support #7

Open kanadaj opened 5 years ago

kanadaj commented 5 years ago

It might be a good idea to make a branch that targets Entity Framework Classic (https://github.com/zzzprojects/EntityFramework-Classic, https://www.nuget.org/packages/Z.EntityFramework.Classic) instead of Entity Framework 6 - the API surface is identical since EF Classic is a fork of EF6, but Classic targets .NET Core 2.0 and higher (I think it's netstandard2.0 but I might be wrong there)

It basically only needs a change to the target framework and libraries used. Extra work to maintain though. Maybe use compiler directives instead?

kanadaj commented 5 years ago

@bruno-garcia

bruno-garcia commented 5 years ago

Don't think we'll be publishing this under Sentry.* namespace. It'd require also docs at docs.sentry.io and it's just too niche. There's 23k downloads only.

This seems like a good candidate for a community package though. You could publish it under your name or join @pengweiqhca in creating a sentry-contrib org on GitHub. I'd be happy to help with setting up the repo to build/publish to NuGet under some SentryContrib namespace.

kanadaj commented 5 years ago

Honestly, it's very minimal effort to make, my biggest problem is that ideally it'd be minimal maintenance with either just adding it to this pipeline or making some automatic release procedure that automatically merges changes to this repo's master branch into that one and pushing it to NuGet, and automating that seems like too much effort.

I also need to point out that EF Classic is extremely new, so 23K downloads is quite amazing :) It's basically the current go-to library foir migrating production apps to .NET Core without having to move to EF Core (which is still often not an option due to all the missing features, including the widely used spatial tables) or using (the rather broken) .NET Core 3.0 preview.